use MessageBuffer constructor reflection only when required#477
Closed
joelnn wants to merge 0 commit intomsgpack:developfrom
Closed
use MessageBuffer constructor reflection only when required#477joelnn wants to merge 0 commit intomsgpack:developfrom
joelnn wants to merge 0 commit intomsgpack:developfrom
Conversation
Member
|
@joelnn We prefer not mixing two or more changes (Unpacker and reflection). Could you make different PRs so that we can check these changes individually? Avoiding reflection is OK, but I'm not sure about MessageUnpacker changes, so I cannot merge this PR. |
xerial
requested changes
May 31, 2018
Member
xerial
left a comment
xerial
left a comment
There was a problem hiding this comment.
Please split PRs into two so that we can check these changes for MessageUnpacker and MessageBuffer individually.
This was referenced Jun 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invoking the MessageBuffer constructor showed up as a hotspot in my profiling. There is no need for it when we are only using MessageBuffer itself, not one of the subclasses.
This patch improves unpackValue performance for my data by about 25%.