Warn on implicit stdio initialization#338
Open
atesgoral wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
Warn on implicit stdio initialization#338atesgoral wants to merge 1 commit intomodelcontextprotocol:mainfrom
atesgoral wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements phase 2 of #334 after the 0.15.0 release.
MCP::Client::Stdio#send_requestperforms the compatibility implicit initialization path.MCP::Client#connectno-warning path.How Has This Been Tested?
dev test-- 847 runs, 2159 assertions, 0 failuresNotes
dev stylecurrently reports existing unrelatedMinitest/AssertEmptyLiteraloffenses in files outside this change. No new offense is reported for the touched files.