add telemetry to send usage data#45
Merged
Eskibear merged 4 commits intomicrosoft:masterfrom Sep 25, 2017
Merged
Conversation
|
@Eskibear, |
andxu
reviewed
Sep 25, 2017
| export const JAVA_BUILD_WORKSPACE = "vscode.java.buildWorkspace"; | ||
|
|
||
| export const JAVA_EXECUTE_WORKSPACE_COMMAND = "java.execute.workspaceCommand"; | ||
| export const VSCODE_STARTDEBUG = "vscode.startDebug"; |
andxu
previously approved these changes
Sep 25, 2017
yaohaizh
reviewed
Sep 25, 2017
| setInterval(function() { | ||
| fetchUsageData().then(ret => { | ||
| if (Array.isArray(ret) && ret.length) { | ||
| ret.forEach(entry => { |
Contributor
There was a problem hiding this comment.
If we are not in debug, this still is still fetching data which is void operation
akaroml
requested changes
Sep 25, 2017
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT license. | ||
|
|
||
| export const VSCODE_STARTDEBUG = "vscode.startDebug"; |
Member
There was a problem hiding this comment.
Why do we have so many changes in this file?
akaroml
approved these changes
Sep 25, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.