feat: accept datetime.timedelta for timeout parameters#3059
Open
Skn0tt wants to merge 1 commit intomicrosoft:mainfrom
Open
feat: accept datetime.timedelta for timeout parameters#3059Skn0tt wants to merge 1 commit intomicrosoft:mainfrom
Skn0tt wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Closes microsoft#2600. Lets users pass datetime.timedelta to any function with a timeout parameter, in addition to a plain float (milliseconds): page.click("div", timeout=timedelta(minutes=5)) The codegen widens every `timeout: float` parameter on the generated public API to `Union[float, datetime.timedelta]` and converts via a new `to_milliseconds` helper at the boundary to the impl layer. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2600.
Lets users pass
datetime.timedeltato any function with atimeoutparameter, in addition to a plain float (milliseconds):The codegen widens every
timeout: floatparameter on the generated public API toUnion[float, datetime.timedelta]and converts via a newto_millisecondshelper at the boundary to the impl layer (which keeps usingfloat, so the doc validator stays happy against the JSnumbertype).The bulk of the diff is regenerated code from
./scripts/update_api.sh.