Fix handling of ignore_default_args when passed as a boolean.#3020
Open
lp07 wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix handling of ignore_default_args when passed as a boolean.#3020lp07 wants to merge 1 commit intomicrosoft:mainfrom
lp07 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
Skn0tt
approved these changes
Apr 30, 2026
Skn0tt
requested changes
Apr 30, 2026
Member
Skn0tt
left a comment
Skn0tt
left a comment
There was a problem hiding this comment.
The tests seem to not be in the right place. I'll take a look later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Passing ignore_default_args=False was sent over the wire as a boolean, but the server expects an array for ignoreDefaultArgs, resulting in:
"expected array, got boolean".
Fix:
Tests:
Added unit tests covering bool True/False and list cases across
chromium, firefox, and webkit.
Related issue: #3005