Fix compute_next_delay returning None when max_retry_interval is not set#116
Merged
YunchuWang merged 2 commits intomainfrom Feb 27, 2026
Merged
Conversation
The compute_next_delay() method in RetryableTask had a bug where the return statement for the computed delay was inside the 'if max_retry_interval is not None' block. When max_retry_interval was not set (the default), the method would fall through and return None, causing retries to silently not happen. This fix moves the return statement outside the max_retry_interval check so the delay is always returned after optional capping. Added two new tests: - test_activity_retry_without_max_retry_interval: verifies retry with exponential backoff works when max_retry_interval is not set - test_activity_retry_with_default_backoff: verifies retry with default backoff_coefficient (1.0) produces constant delays
andystaples
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
compute_next_delay()method inRetryableTaskreturnsNonewhenmax_retry_intervalis not set (the default configuration). This causes retries to silently not happen for the most common RetryPolicy configuration.Fix
Moved the
return timedelta(seconds=next_delay_f)statement outside theif max_retry_interval is not Noneblock so the computed delay is always returned.Tests
Added two new tests to cover the previously-untested code path:
test_activity_retry_without_max_retry_intervaltest_activity_retry_with_default_backoff