Skip to content

attempt proper caching of docker base#96

Merged
stephen-derosa merged 1 commit intolivekit:mainfrom
stephen-derosa:sderosa/fix/base-cache
Apr 15, 2026
Merged

attempt proper caching of docker base#96
stephen-derosa merged 1 commit intolivekit:mainfrom
stephen-derosa:sderosa/fix/base-cache

Conversation

@stephen-derosa
Copy link
Copy Markdown
Contributor

@stephen-derosa stephen-derosa commented Apr 15, 2026

properly use cached base image, not how the base image is not built, instead it is pulled
image

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR attempts to speed up PR-time Docker builds by reusing a cached “base” Docker image from GHCR instead of rebuilding the base image on every run.

Changes:

  • Adds packages: write permission to enable pulling/pushing cached base images to GHCR.
  • Computes a deterministic base-image tag from docker/Dockerfile.base, then pulls-or-builds-and-pushes the base image for amd64 and arm64.
  • Updates SDK image builds to reference the resolved/pulled base image via BASE_IMAGE.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/builds.yml Outdated
Comment thread .github/workflows/builds.yml Outdated
Comment thread .github/workflows/builds.yml Outdated
Comment thread .github/workflows/builds.yml Outdated
@stephen-derosa stephen-derosa force-pushed the sderosa/fix/base-cache branch from 0267367 to 0664d3a Compare April 15, 2026 19:18
@stephen-derosa stephen-derosa merged commit f7d8b11 into livekit:main Apr 15, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants