attempt proper caching of docker base#96
Merged
stephen-derosa merged 1 commit intolivekit:mainfrom Apr 15, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR attempts to speed up PR-time Docker builds by reusing a cached “base” Docker image from GHCR instead of rebuilding the base image on every run.
Changes:
- Adds
packages: writepermission to enable pulling/pushing cached base images to GHCR. - Computes a deterministic base-image tag from
docker/Dockerfile.base, then pulls-or-builds-and-pushes the base image for amd64 and arm64. - Updates SDK image builds to reference the resolved/pulled base image via
BASE_IMAGE.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alan-george-lk
approved these changes
Apr 15, 2026
0267367 to
0664d3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
properly use cached base image, not how the base image is not built, instead it is pulled
