Store configuration files in a subdirectory#175
Open
zoidbergthepopularone wants to merge 1 commit intokanryu:masterfrom
Open
Store configuration files in a subdirectory#175zoidbergthepopularone wants to merge 1 commit intokanryu:masterfrom
zoidbergthepopularone wants to merge 1 commit intokanryu:masterfrom
Conversation
The is preferred due to the better security properties - the directory may be made writable without allowing modifications to the binary files. However, since this breaks compatibility with current installations, it is only used if the directory exists. Otherwise the original behavior (config files directly next to the main binary files) is used.
Author
|
Refers to #71. It's not been tested because I can't compile the sources! |
Owner
|
I think there are two problems with this pull request.
|
Author
|
The process of creating the config directory is not implemented on purpose. I don't want to break the application for people who already have QuickViewer installed. That's why the directory is only used if it already exists. Implementing directory creation and file movement is more than I feel comfortable doing blind. Saving files under AppDir does not solve the problem of configuration files stored in the directory with executables in the portable version. There it also makes sense to separate the configs (writable) and the binaries (read-only). |
Owner
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The is preferred due to the better security properties - the directory may be made writable without allowing modifications to the binary files. However, since this breaks compatibility with current installations, it is only used if the
directory exists. Otherwise the original behavior (config files directly next to the main binary files) is used.