Skip to content

Fix neutral definition for CodeQL 2.13.3 #2467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koesie10 merged 2 commits into from
Jun 2, 2023
Merged

Fix neutral definition for CodeQL 2.13.3 #2467

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b915b8
Fix neutral definition for CodeQL 2.13.3
koesie10 Jun 1, 2023
831b249
Merge branch 'main' into koesie10/fix-neutral-definition
koesie10 Jun 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions extensions/ql-vscode/src/data-extensions-editor/predicates.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,13 +116,14 @@ export const extensiblePredicateDefinitions: Record<
neutral: {
extensiblePredicate: "neutralModel",
// extensible predicate neutralModel(
// string package, string type, string name, string signature, string provenance
// string package, string type, string name, string signature, string kind, string provenance
// );
generateMethodDefinition: (method) => [
method.externalApiUsage.packageName,
method.externalApiUsage.typeName,
method.externalApiUsage.methodName,
method.externalApiUsage.methodParameters,
method.modeledMethod.kind,
"manual",
],
readModeledMethod: (row) => ({
Expand All @@ -131,8 +132,9 @@ export const extensiblePredicateDefinitions: Record<
type: "neutral",
input: "",
output: "",
kind: "",
kind: row[4] as string,
},
}),
supportedKinds: ["summary", "source", "sink"],
},
};