Skip to content

Comments

fix: go back to using root user in Dockerfile#52

Merged
jmeridth merged 1 commit intomainfrom
jm_go_back_to_root_in_container
Sep 25, 2025
Merged

fix: go back to using root user in Dockerfile#52
jmeridth merged 1 commit intomainfrom
jm_go_back_to_root_in_container

Conversation

@jmeridth
Copy link
Contributor

@jmeridth jmeridth commented Sep 25, 2025

Pull Request

Proposed Changes

We have to do this because we have no active way to change permissions to $GITHUB_OUTPUT to a specific user when running the container

Add trivy ignore to top of Dockerfile to pass linting

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • Label as either fix, documentation, enhancement, infrastructure, maintenance, or breaking

We have to do this because we have no active way to change permissions to $GITHUB_OUTPUT to a specific user when running the container

Add trivy ignore to top of Dockerfile to pass linting

Signed-off-by: jmeridth <jmeridth@gmail.com>
@jmeridth jmeridth self-assigned this Sep 25, 2025
Copilot AI review requested due to automatic review settings September 25, 2025 15:09
@github-actions github-actions bot added the fix label Sep 25, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts the Docker container from using a non-root user back to using the root user to resolve permission issues with $GITHUB_OUTPUT in the container runtime environment.

Key changes:

  • Remove non-root user configuration from Dockerfile
  • Add trivy security scanner ignore directive for root user usage

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jmeridth jmeridth merged commit 88bf4a7 into main Sep 25, 2025
39 checks passed
@jmeridth jmeridth deleted the jm_go_back_to_root_in_container branch September 25, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant