Java: Add query for RSA without OAEP#9982
Conversation
|
Looks good to me (only needs rebasing to fix the failing test I think). Asking for a docs review. |
281a412 to
de69827
Compare
|
👋 Docs content first responder here! Adding this to our review board so a writer can review it! 🙇♀️ |
mchammer01
left a comment
There was a problem hiding this comment.
@joefarebrother - this LGTM ✨
I've added a few minor comments or suggestions for your consideration.
Co-authored-by: mc <42146119+mchammer01@users.noreply.github.com>
|
@joefarebrother What're the next steps for this PR? 🤠 I see that your latest commit applies suggestions from @mchammer01 - Does this PR need to go through another doc review pass? Are any additional reviews required apart from the docs review? |
|
@sidshank I think we were waiting for performance evaluation in DCA, but since @aschackmull approved it, it means we're good in that sense and @joefarebrother went ahead with the merge 😄 |
|
Luckily the query looks sufficiently innocent that I'm not too worried about its performance. But if you were waiting for dca then you could just have waited on the merge - I approved the PR, as the QL looks fine, so you could merge whenever you were ready to do so. |
|
Well, I assumed that was the case because of the DCA runs linked to this PR, but @joefarebrother will know for sure. |
|
I was trying to do a DCA run but it wasn't working (now that I think about it I probably just needed to rebase); merged because it was approved and that it seemed unlikely to have a performance issue. |
No description provided.