Ruby: Fix QL tests and Rust compilation error#7043
Merged
aibaars merged 3 commits intogithub:rc/3.3from Nov 3, 2021
Merged
Conversation
nickrolfe
approved these changes
Nov 3, 2021
Contributor
nickrolfe
left a comment
There was a problem hiding this comment.
LGTM.
I can reproduce the Rust error on mac OS with the latest rustc (1.56.1). Note that the same fix was already made on main when we fixed all the problems reported by cargo clippy. I hope it'll merge back cleanly, since they are identical changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason the rust compiler on linux started complaining about the following while accepting the code on windows and osx. I suspect this is due to a newer version of rust on the actions-virtualenvironments .
See also: https://github.com/github/codeql/actions/runs/1412583767
In addition this pull request fixes the dbscheme upgrades tests that started failing. I wonder why they ever worked because the path supplied to
--additional-packsis not a root folder of a pack (it's a subfolder). I suppose thecodeqlCLI has gotten more strict. Failed job here: https://github.com/aibaars/codeql/runs/4079041121?check_suite_focus=trueFinally this pull request adds the workflow paths to the
pathssection ofpushandpull_requesttriggers to ensure they are run whenever we change the workflows.