C++: Test changes for discover_walk#317
Conversation
ian-semmle
added
C++
depends on internal PR
geoffw0
left a comment
geoffw0
left a comment
There was a problem hiding this comment.
This is a big diff, most of the changes appear to be trivial changes related to varargs or unnamed parameters. Nothing stood out to me as obviously wrong.
| | usings.cpp:9:1:9:17 | using namespace N | | ||
| | usings.cpp:18:3:18:13 | using bf | | ||
| | usings.cpp:21:5:21:14 | using gf | | ||
| | usings.cpp:34:3:34:20 | using tbf | |
There was a problem hiding this comment.
Any idea what's happened here?
| | isfromtemplateinstantiation.cpp:93:55:93:55 | return ... | isfromtemplateinstantiation.cpp:93:7:93:15 | myMethod1 | | ||
| | isfromtemplateinstantiation.cpp:94:7:94:15 | declaration of myMethod2 | isfromtemplateinstantiation.cpp:77:26:77:45 | AnotherTemplateClass<T> | | ||
| | isfromtemplateinstantiation.cpp:94:7:94:15 | declaration of myMethod2 | isfromtemplateinstantiation.cpp:97:25:97:60 | myMethod2 | | ||
| | isfromtemplateinstantiation.cpp:94:7:94:15 | declaration of myMethod2 | isfromtemplateinstantiation.cpp:97:52:97:52 | myMethod2 | |
There was a problem hiding this comment.
I'd like @jbj to look at these changes at some point (no need to hold back merging though).
There was a problem hiding this comment.
@ian-semmle and @nickrolfe, have you checked that the test changes in isfromtemplateinstantiation/*.expected are what they should be? These tests are very sensitive to exactly the things you changed in the discover branch, and they contain some of the edge cases that have been problematic in the past.
There was a problem hiding this comment.
The changes look OK to me. There's a new | I | T | row in isfromuninstantiatedtemplate, but that's probably the same issue as the existing rows.
ian-semmle
force-pushed
the
discover_walk
branch
from
8971ef2 to
4e6717b
Compare
ian-semmle
force-pushed
the
discover_walk
branch
from
4e6717b to
ef15523
Compare
Temporarily disable operation call resolution
Kotlin: Workarounds for codeql-cli
4 participants
No description provided.