JavaScript: Fix a bug in ServerSideUrlRedirect#259
Merged
semmle-qlci merged 1 commit intogithub:masterfrom Oct 2, 2018
Merged
Conversation
aibaars
pushed a commit
that referenced
this pull request
Oct 14, 2021
Don't include desugared nodes in the printed AST
smowton
added a commit
to smowton/codeql
that referenced
this pull request
Apr 16, 2022
…ava-type-subs Remove inapplicable TODO re: K<->J type substitution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server-side redirect query did not handle sinks in this case:
because the logic in
Sink.maybeNonLocal()required that a prefix of the sink must be anExpr. In this case, the prefix is found to be aParameterNodewhoseasExpr()has no result.I've refactored
getAPrefixto return aDataFlow::Nodeand only coerce toExprwhen doinggetStringValue().