Skip to content

JavaScript: Update model of DOMException.#257

Merged
xiemaisi merged 1 commit intogithub:masterfrom
xiemaisi:js/fix-DOMException-model
Oct 1, 2018
Merged

JavaScript: Update model of DOMException.#257
xiemaisi merged 1 commit intogithub:masterfrom
xiemaisi:js/fix-DOMException-model

Conversation

@xiemaisi
Copy link
Copy Markdown

@xiemaisi xiemaisi commented Oct 1, 2018

@xiemaisi xiemaisi added the JS label Oct 1, 2018
@xiemaisi xiemaisi requested a review from a team as a code owner October 1, 2018 07:52
@xiemaisi
Copy link
Copy Markdown
Author

xiemaisi commented Oct 1, 2018

Unfortunately there isn't a good way of writing a unit test for this at the moment, but I've verified locally that it fixes the issue.

Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiemaisi xiemaisi merged commit 7518267 into github:master Oct 1, 2018
@xiemaisi xiemaisi deleted the js/fix-DOMException-model branch October 4, 2018 09:35
aibaars pushed a commit that referenced this pull request Oct 14, 2021
CFG: Allow `erb` top-level scopes
smowton added a commit to smowton/codeql that referenced this pull request Apr 16, 2022
…h-type-aliases

Quieten errors relating to generic type aliases
MathiasVP pushed a commit to MathiasVP/ql that referenced this pull request Aug 10, 2025
MathiasVP pushed a commit to MathiasVP/ql that referenced this pull request Aug 21, 2025
…-tmp"

This reverts commit 6d496ee, reversing
changes made to 866977b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant