JavaScript: Replace qltest semmle-extractor-options comments with options files.#2267
Merged
semmle-qlci merged 11 commits intogithub:masterfrom Nov 7, 2019
Merged
Conversation
added 11 commits
November 5, 2019 15:59
… comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I removed
--experimentaloptions that are no longer required. In fact, I think it would make sense for qltest to always pass--experimental(like LGTM does), but that is for a separate PR.The options
--externs,--platform nodeand--source-type moduleapply to a single file and hence cannot easily be replaced withoptionsfile. However, in all three cases the same behaviour can be achieved by adding a comment/code snippet, so that's what I've done.