Java/C#: Introduce kind for neutrals.#12931
Merged
michaelnebel merged 13 commits intogithub:mainfrom May 9, 2023
Merged
Conversation
github-actions
bot
added
C#
DataFlow Library
Go
Java
Python
Ruby
Swift
documentation
labels
michaelnebel
force-pushed
the
neutralkinds
branch
from
acb6d95 to
5ce4ff3
Compare
michaelnebel
force-pushed
the
neutralkinds
branch
from
5ce4ff3 to
b16a6ff
Compare
Contributor
Author
|
DCA looks good. |
jcogs33
reviewed
May 4, 2023
Contributor
jcogs33
left a comment
jcogs33
left a comment
There was a problem hiding this comment.
I added a few minor suggestions about updating comments, otherwise looks reasonable to me.
java/ql/lib/semmle/code/java/dataflow/ExternalFlowExtensions.qll
Outdated
Show resolved
Hide resolved
csharp/ql/lib/semmle/code/csharp/dataflow/ExternalFlowExtensions.qll
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Co-authored-by: Jami <57204504+jcogs33@users.noreply.github.com>
Co-authored-by: Jami <57204504+jcogs33@users.noreply.github.com>
hvitved
approved these changes
May 9, 2023
koesie10
added a commit
to github/vscode-codeql
that referenced
this pull request
Jun 1, 2023
In CodeQL 2.13.3, the definition of the neutralModel predicate has changed to include the `kind`. This updates the definition of the data extensions editor to match the new definition. One caveat is that when selecting a `kind` other than `summary`, the method will not be shown as supported. This is because a `NeutralCallable` only calls into `neutralSummaryElement`. This matches the previous behavior because setting the `kind` to `source` or `sink` only says that the method is either not a source or not a sink, but not both. Only `summary` fully models the method. See: github/codeql#12931 See: https://github.com/github/codeql/blob/ff78ac98d27c7b9f1adffcf235c56855f8348ad0/java/ql/lib/semmle/code/java/dataflow/internal/FlowSummaryImpl.qll#L338 See: https://github.com/github/codeql/blob/ff78ac98d27c7b9f1adffcf235c56855f8348ad0/java/ql/lib/semmle/code/java/dataflow/internal/FlowSummaryImplSpecific.qll#L160
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we introduce a kind for neutrals.
The kind of a neutral is used to describe, whether the neutral is neutral with respect to
summary: They neutral does not have flow through it (ie. no summary flow).source: The neutral is not a source (of any source kind).sink: The neutral is not a sink (of any sink kind).