C#: Re-factor the experimental PotentialTimeBomb to use new API.#12909
Merged
michaelnebel merged 2 commits intogithub:mainfrom May 9, 2023
Merged
C#: Re-factor the experimental PotentialTimeBomb to use new API.#12909michaelnebel merged 2 commits intogithub:mainfrom
michaelnebel merged 2 commits intogithub:mainfrom
Conversation
Contributor
Author
|
DCA looks good and it appears there is a speedup on around 50% for the PotentialTimeBomb query. |
michaelnebel
added
the
no-change-note-required
michaelnebel
force-pushed
the
csharp/dataflowrefactor7
branch
from
650dcce to
d01674f
Compare
hvitved
reviewed
May 8, 2023
csharp/ql/src/experimental/Security Features/backdoor/PotentialTimeBomb.ql
Show resolved
Hide resolved
csharp/ql/src/experimental/Security Features/backdoor/PotentialTimeBomb.ql
Show resolved
Hide resolved
hvitved
approved these changes
May 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are no alerts diff when running the queries on all DCA projects.
The unit test shows a small difference in the produced data flow graph edges: I am a bit uncertain, why that is the case, but there is pretty big difference in how the data flow graph is constructed between the old and the new version. In the old version of the code all sources and sinks are added by extending a "global" configuration. This produces a set of nodes and edges used for data flow analysis in the entire graph - which I suppose might create/remove edges as the configurations get intertwined. However, when using the new API, the graphs are constructed separately for each configuration and then merged afterwards.
I think we can accept this discrepancy, since this doesn't affect the produced results in the unit tests or test projects.