Skip to content

Java: Update MaD Declarations after Triage#12366

Merged
atorralba merged 14 commits intomainfrom
java/update-mad-decls-after-triage-2023-03-02T12-08-59
Mar 21, 2023
Merged

Java: Update MaD Declarations after Triage#12366
atorralba merged 14 commits intomainfrom
java/update-mad-decls-after-triage-2023-03-02T12-08-59

Conversation

@kaeluka
Copy link
Copy Markdown

@kaeluka kaeluka commented Mar 2, 2023 •
edited
Loading

This PR was created by @kaeluka.

TR 2276-2

@github-actions github-actions bot removed the ATM label Mar 2, 2023
@kaeluka kaeluka changed the title Java: Update MaD Declarations after Triage [Test PR, Please Ignore] Java: Update MaD Declarations after Triage Mar 2, 2023
@kaeluka kaeluka marked this pull request as ready for review March 2, 2023 12:11
@kaeluka kaeluka requested a review from a team as a code owner March 2, 2023 12:11
@kaeluka
Copy link
Copy Markdown
Author

kaeluka commented Mar 2, 2023

@atorralba this one is ready for a review :)

jcogs33
jcogs33 reviewed Mar 2, 2023
View reviewed changes
@kaeluka
Copy link
Copy Markdown
Author

kaeluka commented Mar 6, 2023

@jcogs33 @atorralba After what you told me on Fri — that taint flow of constructors goes to Argument[-1], rather than ReturnValue, I just went through this PR and double-checked the decls. I found one that was wrong, and fixed it.

@kaeluka
Copy link
Copy Markdown
Author

kaeluka commented Mar 6, 2023

The MacOS integration tests timed out — I tried rerunning those failed tasks.

@kaeluka
Copy link
Copy Markdown
Author

kaeluka commented Mar 7, 2023

Tests have passed

@kaeluka kaeluka added the ATM label Mar 9, 2023
jcogs33
jcogs33 reviewed Mar 14, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@jcogs33 jcogs33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments about duplicates, sorting, and neutral/non-exploitable sinks.

@github-actions github-actions bot removed the ATM label Mar 14, 2023
@kaeluka
Copy link
Copy Markdown
Author

kaeluka commented Mar 14, 2023 •
edited
Loading

I've updated the PR to move one decl back to its original location, remove some unexploitable sinks, and remove some duplicates.

I think this addresses all comments other than the sorting discussion above, which is still open.

@kaeluka
Copy link
Copy Markdown
Author

kaeluka commented Mar 20, 2023

resolved merge conflicts

atorralba
atorralba reviewed Mar 20, 2023
View reviewed changes
atorralba
atorralba reviewed Mar 20, 2023
View reviewed changes
atorralba
atorralba previously approved these changes Mar 20, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@atorralba atorralba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DCA results looks reasonable, let's merge once CI passes 🚀

@atorralba atorralba force-pushed the java/update-mad-decls-after-triage-2023-03-02T12-08-59 branch from 1732d1a to 1ed366f Compare March 20, 2023 16:11
@atorralba atorralba force-pushed the java/update-mad-decls-after-triage-2023-03-02T12-08-59 branch from 1ed366f to 1258812 Compare March 20, 2023 16:14
@atorralba atorralba merged commit 1f99180 into main Mar 21, 2023
@atorralba atorralba deleted the java/update-mad-decls-after-triage-2023-03-02T12-08-59 branch March 21, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiferet tiferet tiferet left review comments

@jcogs33 jcogs33 jcogs33 left review comments

+1 more reviewer

@atorralba atorralba atorralba approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@atorralba atorralba

Labels

documentation Java

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kaeluka @atorralba @tiferet @jcogs33