TS: fix missing this type in method declarations#1076
Merged
semmle-qlci merged 3 commits intogithub:rc/1.20from Mar 12, 2019
Merged
TS: fix missing this type in method declarations#1076semmle-qlci merged 3 commits intogithub:rc/1.20from
semmle-qlci merged 3 commits intogithub:rc/1.20from
Conversation
Contributor
Author
xiemaisi
reviewed
Mar 12, 2019
xiemaisi
left a comment
xiemaisi
left a comment
There was a problem hiding this comment.
Looks plausible, but tests are unhappy.
xiemaisi
approved these changes
Mar 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For method declarations, the
thisparameter was not included when converting the TypeScript AST to our AST.