WIP chore: upgrade @types/node to v25.2.0 and fix type compatibility#3078
WIP chore: upgrade @types/node to v25.2.0 and fix type compatibility#3078lahirumaramba wants to merge 3 commits intomainfrom
Conversation
Summary of ChangesHello @lahirumaramba, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on maintaining the project's type definition currency by upgrading the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request upgrades the @types/node dependency and addresses the resulting TypeScript compilation errors. The changes correctly handle stricter type definitions for HTTP headers and fix an implicit any error in an event handler. The logic is sound. I have one suggestion to improve code maintainability by reducing duplication.
Description
This PR bumps the
@types/nodedevelopment dependency from^22.8.7to^25.2.0to keep type definitions up to date.As a result of stricter type definitions in newer
@types/nodeversions, this PR also addresses the resulting TypeScript compilation errors by:AsyncHttpCallandAsyncHttp2Callconstructors to use a local variable, allowing TypeScript's control flow analysis to properly resolve the array check and narrow the header types tohttp.OutgoingHttpHeaders.errorparameter asanyin thehttp2Session.on('error', ...)handler to prevent implicit typing errors.