Make httpserver::error_log consume and apply va_list.#298
Merged
etr merged 3 commits intoetr:masterfrom Mar 6, 2023
Merged
Conversation
…erates full log messages. There are a small number of places where error_log is called where it is expected to apply printf style formatting to it's extra arguments. In most of them, the extra arguments are the most important.
…nd va_end_missing. (I don't have a cppcheck setup and I can't seem to make anything fail so I'm kinda gussing here.)
(I don't have a cppcheck setup and I can't seem to make anything fail so I'm kinda gussing here.)
bcsgh
changed the title
httpserver::error_log consume and apply va_list.
Owner
|
Thanks for this as well; it is going to help a lot in streamlining the logging for quite a lot of folks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identify the Bug
#297
Description of the Change
This makes it generate full log messages.
There are a small number of places where error_log is called where it is expected to apply
printfstyle formatting to it's extra arguments. In most of them, the extra arguments are the most important.Alternate Designs
None.
Possible Drawbacks
None?
Verification Process
Building with this commit allowed me to fix the issue I was having using the library.
Release Notes
Make
httpserver::create_webserver::log_errorcallback get fully formatted messages.