Remove ineffective/unneeded const from shared_ptr return types#285
Merged
etr merged 3 commits intoetr:masterfrom Sep 30, 2022
Merged
Remove ineffective/unneeded const from shared_ptr return types#285etr merged 3 commits intoetr:masterfrom
etr merged 3 commits intoetr:masterfrom
Conversation
Owner
|
Thanks for the cleanup. Very much appreciated |
Contributor
|
I know it's a bit late but this should have been flagged as a breaking interface change because existing code that overrides httpserver::http_resource::render_GET etc. now has an "invalid covariant return type" error and there is no way to write code that works with both the old const and new non-const return types. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identify the Bug
#284
Description of the Change
Replace all instances of
const shared_ptr<http_response>withshared_ptr<http_response>Alternate Designs
There is no alternate design
Possible Drawbacks
I don't believe there are any.
Verification Process
All tests pass. Everything compiles fine. clang-tidy no longer reports the issue in a code base that uses this return type.
Release Notes
Remove ineffective/unneeded const from std::shared_ptr <http_response> return types.