Add a getter to allow access to the gnutls_session_t.#233
Merged
etr merged 6 commits intoetr:masterfrom Jun 9, 2021
Merged
Conversation
Contributor
Author
|
FWIW: this reason I want this is to allow access to play around with client side cert based authentication. |
Owner
|
Hey, thanks for the change (and sorry for the delay on this answer). It looks good to me overall. Do you mind adding info into the documentation (the README.md) to make it discoverable? (there is a section dedicated to http_request) |
…get_tls_session is safe to call.
Contributor
Author
|
Done. And while looking at it, I realized there is no easy/safe way to call that method so I added a predicate for checking that. |
etr
requested changes
Jun 9, 2021
Owner
etr
left a comment
There was a problem hiding this comment.
Can we fix a typo in the documentation - with that done, I can merge
Owner
|
Looks good, thanks for the support |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Add a method to yield a handle to the TLS sessions being used by libmicrohttpd for the request,
Alternate Designs
I considered building API's the provide C++ wrappers for the specific TLS API's that would be needed but concluded that is not the job of this library.
Possible Drawbacks
Verification Process
I ran a server using the new method to log data about the session.
And got:
(This is a brand new API, with exactly 2 lines of non-declaration and no flow control. It's either works or it doesn't.)
Release Notes
Add httpserver::http_request::get_tls_session() to allow access to full TLS session.