Conversation
Codecov Report
@@ Coverage Diff @@
## master #190 +/- ##
=======================================
Coverage 95.19% 95.19%
=======================================
Files 35 35
Lines 3140 3140
=======================================
Hits 2989 2989
Misses 151 151
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identify the Bug
The no_single_resource was missing from the create_webserver object.
See also: #189
Description of the Change
Added the no_single_resource method
Alternate Designs
Given that default is false, we could have left the method out but it might still be useful in complex configurations of the builder object.
Possible Drawbacks
None.
Verification Process
Unit tests
Release Notes
Added the no_single_resource method to create_webserver