Sort include (using the Google C++ style pattern). Also add some more…#184
Merged
etr merged 1 commit intoetr:masterfrom Mar 7, 2020
Merged
Sort include (using the Google C++ style pattern). Also add some more…#184etr merged 1 commit intoetr:masterfrom
etr merged 1 commit intoetr:masterfrom
Conversation
… includes where indirection inclusions were broken.
Codecov Report
@@ Coverage Diff @@
## master #184 +/- ##
=======================================
Coverage 95.19% 95.19%
=======================================
Files 35 35
Lines 3140 3140
=======================================
Hits 2989 2989
Misses 151 151
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identify the Bug
#177 (General code style issues)
Description of the Change
Sort include (using the Google C++ style pattern).
The pattern I'm recommending is:
This is somewhat complicated by the
#if WINDOWS ...stuff, but there wasn't many of those.Also this shuffling surface some files that used symbols that were not defined in a header they included. It seems rather that they were depending on the needed header having already been included by something up the stack.
Alternate Designs
Leaving it as whatever.
Possible Drawbacks
It's possible this could break a consuming build somehow, however any break should be fixable by adding some needed header (probably in the consuming code) which should be done anyway.
Verification Process
Release Notes
Sort include (using the Google C++ style pattern).