Use map lookups for LocalModList#2054
Open
ethangreen-dev wants to merge 1 commit intoebkr:developfrom
Open
Conversation
ethangreen-dev
force-pushed
the
modlist-but-faster
branch
from
e0d6a8f to
63d3be8
Compare
ebkr
requested changes
Jan 22, 2026
| return state.modList; | ||
| }, | ||
|
|
||
| modMap(state): Map<string, ManifestV2> { |
Owner
There was a problem hiding this comment.
Is this not rebuilding the map every time this getter is called?
| public static getDependencyList(manifestMod: ManifestV2, modList: ManifestV2[], dependencySet?: Set<ManifestV2>): Set<ManifestV2> { | ||
| public static getDependencyList( | ||
| manifestMod: ManifestV2, | ||
| modList: ManifestV2[], |
Owner
There was a problem hiding this comment.
I think we should be replacing modList entirely with modMap otherwise we're having double the memory consumption
| const index = new Map<string, ManifestV2[]>(); | ||
| for (const mod of modList) { | ||
| for (const dep of mod.getDependencies()) { | ||
| const depName = dep.substring(0, dep.lastIndexOf('-')); |
Owner
There was a problem hiding this comment.
Same outcome but you have changed the logic here. I'd probably say to revert so that it's a bit easier to read and doesn't rely on knowing the format as much.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.