Added exception.py to setuptools script#101
Merged
codingo merged 1 commit intocodingo:masterfrom Apr 15, 2020
ojasookert:master
Merged
Added exception.py to setuptools script#101codingo merged 1 commit intocodingo:masterfrom ojasookert:master
codingo merged 1 commit intocodingo:masterfrom
ojasookert:master
Conversation
Contributor
|
Whoops, that one was me. I forgot to update |
bbeale
approved these changes
Apr 15, 2020
codingo
approved these changes
Apr 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After Added base exception class NoSQLMapException inside exception.py. #99, using NoSQLMap when installed with
python setup.py installfails with the following log:Without installing with
python setup.py install, this command completes successfully. After some debugging it looks like theexception.pyis not installed with setuptools - adding the filename to the scripts list insetup.pyfixes the issue.