Merged
Conversation
|
✅ Preview binaries are ready! To test with modules: |
This was referenced Feb 19, 2026
DanielleMaywood
approved these changes
Feb 24, 2026
johnstcn
force-pushed
the
cj/exp/acp-b
branch
from
eb2e202 to
3d18f71
Compare
johnstcn
force-pushed
the
cj/exp/acp-c
branch
from
f24f7bb to
c5a2122
Compare
johnstcn
force-pushed
the
cj/exp/acp-c
branch
from
c5a2122 to
7ee60ac
Compare
johnstcn
commented
Feb 25, 2026
Comment on lines
239
to
244
| // The ACP SDK dispatches SessionUpdate notifications as goroutines, so | ||
| // the chunk may arrive after conn.Prompt() returns. Wait up to 100ms. | ||
| select { | ||
| case <-c.chunkReceived: | ||
| case <-time.After(100 * time.Millisecond): | ||
| } |
Member
Author
There was a problem hiding this comment.
review: I'm not super happy with this but it seems to do the job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to coder/internal#1333
Adds e2e test for ACP conversation
🤖 Written by Opus 4.5 using Mux