Conversation
griffinmyers
left a comment
griffinmyers
left a comment
There was a problem hiding this comment.
Looking great! a few comments.
pybutton/resources/transactions.py
Outdated
|
|
||
|
|
||
| Args: | ||
| account_id (str) optional: A Button account id ('acc-XXX') |
There was a problem hiding this comment.
Good catch! Done.
| print(response) | ||
| # <class pybutton.Response id: customer-1234, ...> | ||
|
|
||
| Transactions |
There was a problem hiding this comment.
please add description for how this differs from accounts#transactions.
There was a problem hiding this comment.
Added, not sure if I used the right convention in the description, though.
| * ``cursor`` (string): An API cursor to fetch a specific set of results. | ||
| * ``start`` (ISO-8601 datetime string): Fetch transactions after this time. | ||
| * ``end`` (ISO-8601 datetime string): Fetch transactions before this time. | ||
| * ``time_field`` (string): Which time field ``start`` and ``end`` filter on. |
README.rst
Outdated
|
|
||
| client = Client('sk-XXX') | ||
|
|
||
| response = client.accounts.transactions( |
There was a problem hiding this comment.
Fixed! Thanks!
|
Did you want to add |
|
|
nathanielmiller20
force-pushed
the
nm/txs
branch
from
e2fbedb to
eddb7a7
Compare
griffinmyers
left a comment
griffinmyers
left a comment
There was a problem hiding this comment.
LGTM! I think you have one linting failure that is a consequence of a branch I merged underneath you--let's make sure the build passes and merge up!
2 participants
Seems we don't have some python version binaries we need? About half the versions are passing and about half can't be found.