KAFKA-19943: Implement state store clean up on start#21566
Open
UladzislauBlok wants to merge 4 commits intoapache:trunkfrom
Open
KAFKA-19943: Implement state store clean up on start#21566UladzislauBlok wants to merge 4 commits intoapache:trunkfrom
UladzislauBlok wants to merge 4 commits intoapache:trunkfrom
Conversation
UladzislauBlok
force-pushed
the
bloku/kafka-19943
branch
from
e76fe2d to
ca227ba
Compare
UladzislauBlok
changed the title
UladzislauBlok
changed the title
UladzislauBlok
commented
Feb 24, 2026
|
|
||
| private void cleanStateAndTaskDirectoriesOnStartup(final long dirMaxAgeMs) throws Exception { | ||
| if (!lockedTasksToOwner.isEmpty()) { | ||
| log.warn("Found some still-locked task directories when cleaning outdated directories"); |
Contributor
Author
There was a problem hiding this comment.
That shouldn't be the case, so I wasn't sure log warn / error or throw an exception
| public synchronized void start() throws IllegalStateException, StreamsException { | ||
| if (setState(State.REBALANCING)) { | ||
| final Long dirMaxAgeMs = applicationConfigs.getLong(StreamsConfig.STATE_CLEANUP_DIR_MAX_AGE_MS_CONFIG); | ||
| if (dirMaxAgeMs != StreamsConfig.STATE_CLEANUP_DIR_MAX_AGE_MS_DISABLED) { |
Contributor
Author
There was a problem hiding this comment.
I didn't add test for this one, because it's super simple. I can add one if anyone think that will be usefull
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation for KIP-1259