systemvmtemplate-register: fix using existing template for new zone#12704
Draft
shwstppr wants to merge 1 commit intoapache:4.22from
Draft
systemvmtemplate-register: fix using existing template for new zone#12704shwstppr wants to merge 1 commit intoapache:4.22from
shwstppr wants to merge 1 commit intoapache:4.22from
Conversation
Fixes apache#12434 When adding a new zone it won't be always correct to assume that template name returned by router hypervisor template config for the new zone is pointing to the correct template. Backported from `main` and updated the code first find a registered template by name. If not present, then find an active template which has the same url path. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
shwstppr
force-pushed
the
fix-readding-systemp-newzone
branch
from
5489094 to
e02910f
Compare
Contributor
Author
|
@blueorangutan package |
|
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16938 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #12434
When adding a new zone it won't be always correct to assume that template name returned by router hypervisor template config for the new zone is pointing to the correct template.
Backported from
mainand updated the code first find a registered template by name. If not present, then find an active template which has the same url path.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?