refactor: drop protractor by hawkgs · Pull Request #32562 · angular/angular-cli

hawkgs · 2026-02-24T14:57:50Z

PR Checklist

Please check to confirm your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

What is the new behavior?

Drop Protractor from the respository since it's no longer supported.

Does this PR introduce a breaking change?

Yes
No

tests/angular_devkit/core/json/schema/serializers/schema_benchmark.json

clydin · 2026-02-24T17:57:29Z

Can you also split this into two commits?
Probably one for @schematics/angular with the schematic removal and one for @angular-devkit/build-angular with the builder/dep removal.

Protractor is no longer supported and has been deprecated since v19.

Remove Protractor since it's no longer supported and has been deprecated since v19; Remove the dependency.

alan-agius4 · 2026-02-25T13:57:25Z

packages/angular_devkit/build_angular/BUILD.bazel

@@ -49,11 +49,6 @@ ts_json_schema(
    src = "src/builders/karma/schema.json",


Please remove Protractor from https://github.com/angular/angular-cli/blob/main/packages/angular_devkit/build_angular/README.md

alan-agius4 · 2026-02-25T14:00:06Z

packages/schematics/angular/utility/workspace-models.ts

 export type ServeBuilderTarget = BuilderTarget<Builders.DevServer, ServeBuilderOptions>;
 export type ExtractI18nBuilderTarget = BuilderTarget<Builders.ExtractI18n, ExtractI18nOptions>;
-export type E2EBuilderTarget = BuilderTarget<Builders.Protractor, E2EOptions>;
+export type E2EBuilderTarget = BuilderTarget<E2eExternalBuilders, E2EOptions>;


We no longer need this, also remove E2EOptions

Suggested change

export type E2EBuilderTarget = BuilderTarget<E2eExternalBuilders, E2EOptions>;

alan-agius4 · 2026-02-25T14:00:14Z

packages/schematics/angular/utility/workspace-models.ts

 }

-export interface BuilderTarget<TBuilder extends Builders, TOptions> {
+export interface BuilderTarget<TBuilder extends Builders | E2eExternalBuilders, TOptions> {


Suggested change

export interface BuilderTarget<TBuilder extends Builders | E2eExternalBuilders, TOptions> {

export interface BuilderTarget<TBuilder extends Builders, TOptions> {

alan-agius4 · 2026-02-25T14:00:48Z

packages/schematics/angular/utility/workspace-models.ts

+/**
+ * An enum of E2E external builders.
+ * Each enum value provides the fully qualified name of the associated builder.
+ */
+enum E2eExternalBuilders {
+  Playwright = 'playwright-ng-schematics:playwright',
+  Cypress = '@cypress/schematic:cypress',
+  Nightwatch = '@nightwatch/schematics:nightwatch',
+  WebdriverIO = '@wdio/schematics:wdio',
+  Puppeteer = '@puppeteer/ng-schematics:puppeteer',
+}
+


Suggested change

/**

* An enum of E2E external builders.

* Each enum value provides the fully qualified name of the associated builder.

*/

enum E2eExternalBuilders {

Playwright = 'playwright-ng-schematics:playwright',

Cypress = '@cypress/schematic:cypress',

Nightwatch = '@nightwatch/schematics:nightwatch',

WebdriverIO = '@wdio/schematics:wdio',

Puppeteer = '@puppeteer/ng-schematics:puppeteer',

}

alan-agius4

ts-node should also be removed as a dependencies in all package.json

alan-agius4 · 2026-02-25T14:33:43Z

tests/e2e/tests/misc/browsers.ts

@@ -1,93 +0,0 @@
-import express from 'express';


This tests it needs, it seems that it was not migrated yet to not use protractor.

angular-cli/.github/workflows/ci.yml

Lines 203 to 238 in bfdc7b0

browsers:

needs: build

runs-on: ubuntu-latest

name: Browser Compatibility Tests

env:

SAUCE_TUNNEL_IDENTIFIER: angular-cli-${{ github.workflow }}-${{ github.run_number }}

steps:

- name: Initialize environment

uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@16c5f6e199e3e1b67ae5a62385d36366bb9a429d

- name: Install node modules

run: pnpm install --frozen-lockfile

- name: Setup Bazel

uses: angular/dev-infra/github-actions/bazel/setup@16c5f6e199e3e1b67ae5a62385d36366bb9a429d

- name: Setup Bazel RBE

uses: angular/dev-infra/github-actions/bazel/configure-remote@16c5f6e199e3e1b67ae5a62385d36366bb9a429d

with:

google_credential: ${{ secrets.RBE_TRUSTED_BUILDS_USER }}

- name: Run E2E Browser tests

env:

SAUCE_USERNAME: ${{ vars.SAUCE_USERNAME }}

SAUCE_ACCESS_KEY: ${{ secrets.SAUCE_ACCESS_KEY }}

SAUCE_LOG_FILE: /tmp/angular/sauce-connect.log

SAUCE_READY_FILE: /tmp/angular/sauce-connect-ready-file.lock

SAUCE_PID_FILE: /tmp/angular/sauce-connect-pid-file.lock

SAUCE_TUNNEL_IDENTIFIER: 'angular-${{ github.run_number }}'

SAUCE_READY_FILE_TIMEOUT: 120

run: |

./scripts/saucelabs/start-tunnel.sh &

./scripts/saucelabs/wait-for-tunnel.sh

pnpm bazel test --config=saucelabs //tests:e2e.saucelabs

./scripts/saucelabs/stop-tunnel.sh

- uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0

if: ${{ failure() }}

with:

name: sauce-connect-log

path: ${{ env.SAUCE_CONNECT_DIR_IN_HOST }}/sauce-connect.log

//cc @clydin

So we should update it with any of the new E2E tools or rather create new tests from scratch?

I had the impression that it's Protractor-specific.

hawkgs force-pushed the drop-protractor branch from 42c9e3a to 27f9810 Compare February 24, 2026 15:48

hawkgs commented Feb 24, 2026

View reviewed changes

tests/angular_devkit/core/json/schema/serializers/schema_benchmark.json Show resolved Hide resolved

hawkgs added 2 commits February 25, 2026 14:22

refactor(@schematics/angular): remove protractor e2e schematic

101ce35

Protractor is no longer supported and has been deprecated since v19.

refactor(@angular-devkit/build-angular): remove protractor

fb465eb

Remove Protractor since it's no longer supported and has been deprecated since v19; Remove the dependency.

hawkgs force-pushed the drop-protractor branch from 27f9810 to fb465eb Compare February 25, 2026 12:31

angular-robot bot added area: @schematics/angular area: @angular-devkit/build-angular labels Feb 25, 2026

hawkgs marked this pull request as ready for review February 25, 2026 13:17

hawkgs requested a review from clydin February 25, 2026 13:17

alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Feb 25, 2026

alan-agius4 reviewed Feb 25, 2026

View reviewed changes

alan-agius4 added the target: major This PR is targeted for the next major release label Feb 25, 2026

alan-agius4 reviewed Feb 25, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: drop protractor#32562

refactor: drop protractor#32562
hawkgs wants to merge 2 commits intoangular:mainfrom
hawkgs:drop-protractor

hawkgs commented Feb 24, 2026

Uh oh!

Uh oh!

clydin commented Feb 24, 2026

Uh oh!

alan-agius4 Feb 25, 2026

Uh oh!

alan-agius4 Feb 25, 2026

Uh oh!

alan-agius4 Feb 25, 2026

Uh oh!

alan-agius4 Feb 25, 2026

Uh oh!

alan-agius4 left a comment

Uh oh!

alan-agius4 Feb 25, 2026

Uh oh!

hawkgs Feb 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -49,11 +49,6 @@ ts_json_schema(
		src = "src/builders/karma/schema.json",

	export interface BuilderTarget<TBuilder extends Builders \| E2eExternalBuilders, TOptions> {
	export interface BuilderTarget<TBuilder extends Builders, TOptions> {

	browsers:
	needs: build
	runs-on: ubuntu-latest
	name: Browser Compatibility Tests
	env:
	SAUCE_TUNNEL_IDENTIFIER: angular-cli-${{ github.workflow }}-${{ github.run_number }}
	steps:
	- name: Initialize environment
	uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@16c5f6e199e3e1b67ae5a62385d36366bb9a429d
	- name: Install node modules
	run: pnpm install --frozen-lockfile
	- name: Setup Bazel
	uses: angular/dev-infra/github-actions/bazel/setup@16c5f6e199e3e1b67ae5a62385d36366bb9a429d
	- name: Setup Bazel RBE
	uses: angular/dev-infra/github-actions/bazel/configure-remote@16c5f6e199e3e1b67ae5a62385d36366bb9a429d
	with:
	google_credential: ${{ secrets.RBE_TRUSTED_BUILDS_USER }}
	- name: Run E2E Browser tests
	env:
	SAUCE_USERNAME: ${{ vars.SAUCE_USERNAME }}
	SAUCE_ACCESS_KEY: ${{ secrets.SAUCE_ACCESS_KEY }}
	SAUCE_LOG_FILE: /tmp/angular/sauce-connect.log
	SAUCE_READY_FILE: /tmp/angular/sauce-connect-ready-file.lock
	SAUCE_PID_FILE: /tmp/angular/sauce-connect-pid-file.lock
	SAUCE_TUNNEL_IDENTIFIER: 'angular-${{ github.run_number }}'
	SAUCE_READY_FILE_TIMEOUT: 120
	run: \|
	./scripts/saucelabs/start-tunnel.sh &
	./scripts/saucelabs/wait-for-tunnel.sh
	pnpm bazel test --config=saucelabs //tests:e2e.saucelabs
	./scripts/saucelabs/stop-tunnel.sh
	- uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0
	if: ${{ failure() }}
	with:
	name: sauce-connect-log
	path: ${{ env.SAUCE_CONNECT_DIR_IN_HOST }}/sauce-connect.log

Conversation

hawkgs commented Feb 24, 2026

PR Checklist

PR Type

What is the new behavior?

Does this PR introduce a breaking change?

Uh oh!

Uh oh!

clydin commented Feb 24, 2026

Uh oh!

alan-agius4 Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

alan-agius4 Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

alan-agius4 Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

alan-agius4 Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

alan-agius4 left a comment

Choose a reason for hiding this comment

Uh oh!

alan-agius4 Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

hawkgs Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants