feat(@angular-devkit/build-angular): remove inlining of assets in css#12027
Merged
vikerman merged 1 commit intoangular:masterfrom Aug 29, 2018
alan-agius4:remove_inline_styles
Merged
feat(@angular-devkit/build-angular): remove inlining of assets in css#12027vikerman merged 1 commit intoangular:masterfrom alan-agius4:remove_inline_styles
vikerman merged 1 commit intoangular:masterfrom
alan-agius4:remove_inline_styles
Conversation
alan-agius4
added
the
target: major
BREAKING CHANGE: Assets under 10Kib are not longer inlined in css
filipesilva
approved these changes
Aug 29, 2018
Contributor
filipesilva
left a comment
filipesilva
left a comment
There was a problem hiding this comment.
LGTM
@clydin can you take a look to see if there's more code that should be removed from the CSS pipeline?
Collaborator
Author
|
@filipesilva, I think there is but I was gonna do a separate PR to keep the scope of the PR small, What do you reckon? |
Member
|
postcss-url can be removed completely with some additional refactoring but I agree a separate PR would be appropriate for that. |
Contributor
|
Sure, sgtm. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Assets under 10Kib are not longer inlined in css
superseeds #11826