Skip to content

fix: reducing log level for noisy log and adding details for developer log #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SamuelBellomo merged 5 commits into from
Jun 30, 2021
Merged

fix: reducing log level for noisy log and adding details for developer log #926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9a5bef3
putting log level for delta warning to developer. This was generating…
SamuelBellomo Jun 27, 2021
df690b5
Merge branch 'develop' into fix/perf-fixes-after-spawning-1k-net-obj
0xFA11 Jun 28, 2021
f16c6c2
Merge branch 'develop' into fix/perf-fixes-after-spawning-1k-net-obj
SamuelBellomo Jun 29, 2021
954e299
Merge branch 'develop' into fix/perf-fixes-after-spawning-1k-net-obj
SamuelBellomo Jun 29, 2021
5dd6537
Merge branch 'develop' into fix/perf-fixes-after-spawning-1k-net-obj
SamuelBellomo Jun 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion com.unity.multiplayer.mlapi/Runtime/Core/NetworkManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1182,7 +1182,7 @@ internal void HandleIncomingData(ulong clientId, NetworkChannel networkChannel,

if (NetworkLog.CurrentLogLevel <= LogLevel.Developer)
{
NetworkLog.LogInfo($"Data Header: {nameof(messageType)}={messageType}");
NetworkLog.LogInfo($"Handling incoming Data Header: {nameof(messageType)}={NetworkConstants.MESSAGE_NAMES[messageType]}(int={messageType})");
}

// Client tried to send a network message that was not the connection request before he was accepted.
Expand Down
2 changes: 1 addition & 1 deletion com.unity.multiplayer.mlapi/Runtime/Messaging/InternalMessageHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ public void HandleNetworkVariableDelta(ulong clientId, Stream stream, Action<ulo
}
else
{
if (NetworkLog.CurrentLogLevel <= LogLevel.Normal)
if (NetworkLog.CurrentLogLevel <= LogLevel.Developer)
{
NetworkLog.LogWarning($"{nameof(NetworkConstants.NETWORK_VARIABLE_DELTA)} message received for a non-existent object with {nameof(networkObjectId)}: {networkObjectId}. This delta will be buffered and might be recovered.");
}
Expand Down