test: remote config support for multiprocesstestscene#1931
Merged
NoelStephensUnity merged 20 commits intodevelopfrom May 25, 2022
Merged
test: remote config support for multiprocesstestscene#1931NoelStephensUnity merged 20 commits intodevelopfrom
NoelStephensUnity merged 20 commits intodevelopfrom
Conversation
testproject/Assets/Tests/Runtime/MultiprocessRuntime/Helpers/ConfigurationTools.cs
Outdated
Show resolved
Hide resolved
testproject/Assets/Tests/Runtime/MultiprocessRuntime/Helpers/ConfigurationTools.cs
Outdated
Show resolved
Hide resolved
testproject/Assets/Tests/Runtime/MultiprocessRuntime/Helpers/ConfigurationTools.cs
Outdated
Show resolved
Hide resolved
testproject/Assets/Tests/Runtime/MultiprocessRuntime/Helpers/ConfigurationTools.cs
Outdated
Show resolved
Hide resolved
testproject/Assets/Tests/Runtime/MultiprocessRuntime/Helpers/ConfigurationTools.cs
Outdated
Show resolved
Hide resolved
testproject/Assets/Tests/Runtime/MultiprocessRuntime/Helpers/ConfigurationTools.cs
Outdated
Show resolved
Hide resolved
testproject/Assets/Tests/Runtime/MultiprocessRuntime/TestCoordinator.cs
Outdated
Show resolved
Hide resolved
zain-mecklai
requested review from
NoelStephensUnity
and removed request for
0xFA11
Contributor
Author
|
@SamuelBellomo and @NoelStephensUnity as per previous requests, I've made this as small as possible but there are still several more PRs that are queued up after this one that build on this first piece of work. There are plenty of design issues to be addressed and I'll continue to work on them through the rest of PRs and get them in as small changes |
…nator when the connection is complete
SamuelBellomo
approved these changes
May 24, 2022
0xFA11
approved these changes
May 25, 2022
Contributor
0xFA11
left a comment
0xFA11
left a comment
There was a problem hiding this comment.
I'm probably not the right person to review this PR but just approving to unblock you from moving forward.
|
|
||
| public class MultiprocessLogHandler : ILogHandler | ||
| { | ||
| public static long JobId; |
Member
There was a problem hiding this comment.
Job ID will be helpful indeed! (just catching up to this PR)
NoelStephensUnity
deleted the
test/remote_config_support_for_multiprocesstestscene
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a way for the test to pull configuration data (client ip and port) via a webapi. The main reason for this is because some platforms (like Android) make it difficult to impossible to use command line arguments to configure a client application.