-
Notifications
You must be signed in to change notification settings - Fork 459
feat: added tip to the network manager inspector that directs to install tools (MTT-1211) #1182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
4383159
feat: added tip to the network manager inspector that directs to the …
becksebenius-unity fcb1242
capitalized Package Manager
becksebenius-unity 2e16b97
PR feedback
becksebenius-unity e49de81
Merge branch 'develop' into feature/add-tools-tip
becksebenius-unity 6f3a0b9
method rename
becksebenius-unity ce966c5
removed some unnecessary lines
becksebenius-unity 11803ca
Merge branch 'feature/add-tools-tip' of github.com:Unity-Technologies…
becksebenius-unity cb58b3d
standards fixes
becksebenius-unity 1b7b4ba
standards checks
becksebenius-unity 338d0c3
Merge branch 'develop' into feature/add-tools-tip
becksebenius-unity ba6a61e
Merge branch 'develop' into feature/add-tools-tip
becksebenius-unity File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| using System.Runtime.CompilerServices; | ||
|
|
||
| [assembly: InternalsVisibleTo("Unity.Netcode.EditorTests")] |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
15 changes: 15 additions & 0 deletions
15
com.unity.netcode.gameobjects/Tests/Editor/UI/UITestHelpers.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| using Unity.Netcode.Editor; | ||
| using UnityEditor; | ||
| using UnityEngine; | ||
|
|
||
| namespace Unity.Netcode.EditorTests | ||
| { | ||
| internal static class UITestHelpers | ||
| { | ||
| [MenuItem("Netcode/UI/Reset Multiplayer Tools Tip Status")] | ||
| private static void ResetMultiplayerToolsTipStatus() | ||
| { | ||
| PlayerPrefs.DeleteKey(NetworkManagerEditor.InstallMultiplayerToolsTipDismissedPlayerPrefKey); | ||
| } | ||
| } | ||
| } |
3 changes: 3 additions & 0 deletions
3
com.unity.netcode.gameobjects/Tests/Editor/UI/UITestHelpers.cs.meta
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this coming up because you have MP TOOLS package installed locally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this is an intentional change, it's present in other assemblies but we didn't have any tools integration in this assembly until now.