Skip to content

chore: Disable test while we reevaluate the assumption that INetworkM… #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kvassall-unity merged 4 commits into from
Sep 10, 2021
Merged

chore: Disable test while we reevaluate the assumption that INetworkM… #1163

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3abace7
chore: Disable test while we reevaluate the assumption that INetworkM…
kvassall-unity Sep 9, 2021
ad36198
Use ignore attribute
kvassall-unity Sep 9, 2021
6901dad
Merge branch 'develop' into feature/test_removal
kvassall-unity Sep 10, 2021
ae2dbcd
Merge branch 'develop' into feature/test_removal
becksebenius-unity Sep 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion com.unity.netcode.gameobjects/Tests/Editor/Metrics/NetworkMetricsRegistrationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public class NetworkMetricsRegistrationTests
.Where(x => x.GetInterfaces().Contains(typeof(INetworkMetricEvent)))
.ToArray();

[TestCaseSource(nameof(s_MetricTypes))]
[TestCaseSource(nameof(s_MetricTypes))][Ignore("Disable test while we reevaluate the assumption that INetworkMetricEvent interfaces must be reported from MLAPI.")]
public void ValidateThatAllMetricTypesAreRegistered(Type metricType)
{
var dispatcher = new NetworkMetrics().Dispatcher as MetricDispatcher;
Expand Down