chore: support standalone mode for netcode runtimetests#1115
Merged
JesseOlmer merged 4 commits intodevelopfrom Aug 31, 2021
Merged
chore: support standalone mode for netcode runtimetests#1115JesseOlmer merged 4 commits intodevelopfrom
JesseOlmer merged 4 commits intodevelopfrom
Conversation
Contributor
JesseOlmer
commented
Aug 30, 2021
JesseOlmer
commented
- Move GlobalObjectIdHash tests out of package tests and into testproject
- Move ObjectParenting tests out of package tests and into testproject
- Fix InternalsVisibleTo to work outside of editor for RuntimeTests assembly
- if UNITY_EDITOR guards on editor attributes in SIPTransport
- Move GlobalObjectIdHash tests out of package tests and into testproject - Move ObjectParenting tests out of package tests and into testproject - Fix InternalsVisibleTo to work outside of editor for RuntimeTests assembly - if UNITY_EDITOR guards on editor attributes in SIPTransport
Contributor
Author
|
@zain-mecklai this should add a significant amount of test coverage to the standalone tests - 1405 tests by my count. |
mattwalsh-unity
approved these changes
Aug 30, 2021
0xFA11
reviewed
Aug 31, 2021
| var execAssembly = Assembly.GetExecutingAssembly(); | ||
| var packagePath = PackageInfo.FindForAssembly(execAssembly).assetPath; | ||
| var scenePath = Path.Combine(packagePath, $"Tests/Runtime/GlobalObjectIdHash/{nameof(NetworkObjectGlobalObjectIdHashTests)}.unity"); | ||
| const string scenePath = "Assets/Tests/Runtime/GlobalObjectIdHash/" + nameof(NetworkObjectGlobalObjectIdHashTests) + ".unity"; |
Contributor
There was a problem hiding this comment.
less programmatic but also less dependent — path looks clear and obvious to me, so I think this is fine.
Contributor
There was a problem hiding this comment.
Do these paths work on mobile platforms?
Contributor
There was a problem hiding this comment.
AFAIK, they should. IIRC, Assets/xxx is a project relative path and not directly OS-dependent.
SamuelBellomo
added a commit
that referenced
this pull request
Sep 2, 2021
…nsform * develop: (26 commits) fix: client connected InvokeOnClientConnectedCallback with scene management disabled (#1123) fix: removed `public` class `NetcodeObserver` (MTT-1157) (#1122) feat: add NetworkMessageSent/Received metrics (#1112) feat: snapshot. MTU sizing option for Snapshot. MTT-1087 (#1111) Add metrics for transport bytes sent and received (#1104) fix: Missing end profiling sample (#1118) chore: support standalone mode for netcode runtimetests (#1115) feat: Change MetricNames for a more complex value type (#1109) feat: Track scene event metrics (#1089) style: whitespace fixes (#1117) feat: replace scene registration with scenes in build list (#1080) fix: mtt-857 GitHub issue 915 (#1099) fix: NetworkSceneManager exception when DontDestroyOnLoad NetworkObjects are being synchronized (#1090) feat: NetworkTransform Custom Editor Inspector UI (#1101) refactor: remove TempGlobalObjectIdHashOverride (#1105) fix: MTT-1124 Counters are now reported in sync with other metrics (#1096) refactor: convert using var statements to using var declarations (#1100) chore: updated all of the namespaces to match the tools package change (#1095) refactor!: remove network variable settings, network behaviour cleanup (#1097) fix: mtt-1088 review. Safer handling of out-of-order or old messages (#1091) ... # Conflicts: # com.unity.netcode.gameobjects/Prototyping/NetworkTransform.cs
mollstam
pushed a commit
to Keepsake-Games/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 13, 2023
…logies#1115) - Move GlobalObjectIdHash tests out of package tests and into testproject - Move ObjectParenting tests out of package tests and into testproject - Fix InternalsVisibleTo to work outside of editor for RuntimeTests assembly - if UNITY_EDITOR guards on editor attributes in SIPTransport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.