Feature/initial relay utp remove relay sdk calls#1034
Merged
thoward-unity merged 6 commits intofeature/initial-relay-utpfrom Aug 10, 2021
Merged
Conversation
…ow accepts a variable passed in via a setter method. Also updated the sample test project included to illustrate these changes.
…tructured the manner that code external to UTPTransport passes in the requisite relay server data so that external code doesn't need to know about the internal data structures that UTPTransport uses.
…king other approaches.
…Technologies/com.unity.multiplayer.mlapi into feature/initial-relay-utp-remove-relay-sdk-calls
simon-lemay-unity
approved these changes
Aug 9, 2021
Contributor
simon-lemay-unity
left a comment
simon-lemay-unity
left a comment
There was a problem hiding this comment.
Added a few comments, but no major blockers for me.
andrews-unity
approved these changes
Aug 10, 2021
thoward-unity
deleted the
feature/initial-relay-utp-remove-relay-sdk-calls
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted Relay SDK calls out of UTP adapter for MLAPI; it now accepts a variable passed in via a setter method. Also updated the sample test project included to illustrate these changes.
Made some changes that address feedback comments; mainly restructured the manner that code external to UTPTransport passes in the requisite relay server data so that external code doesn't need to know about the internal data structures that UTPTransport uses.
Removed minor changes that were erroneously left in when taking other approaches.