feat: Adding channels for those that just want to know what they do.#1029
Closed
SamuelBellomo wants to merge 1 commit intodevelopfrom
Closed
feat: Adding channels for those that just want to know what they do.#1029SamuelBellomo wants to merge 1 commit intodevelopfrom
SamuelBellomo wants to merge 1 commit intodevelopfrom
Conversation
SamuelBellomo
requested review from
0xFA11,
LukeStampfli,
ShadauxCat and
andrews-unity
0xFA11
reviewed
Aug 9, 2021
Comment on lines
+22
to
+26
| ReliableSequenced, | ||
| ReliableUnsequenced, | ||
| ReliableFragmentedSequenced, | ||
| UnreliableSequenced, | ||
| UnreliableUnsequenced, |
Contributor
There was a problem hiding this comment.
FWIW, I believe we're planning to get rid of the explicit transport QoS channel specification as a whole soon :)
Contributor
There was a problem hiding this comment.
Yes, really soon :)
LukeStampfli
approved these changes
Aug 25, 2021
Contributor
LukeStampfli
left a comment
LukeStampfli
left a comment
There was a problem hiding this comment.
I think as long as we have channels this is a great addition because without this it is really tricky to just get a channel with the right QoS.
Contributor
|
Channels are gone from dev so I think we can close this PR |
Contributor
yes, channels are gone with PR #1133 |
Contributor
Author
|
closing as this isn't relevant anymore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't want to create an RFC for this, but I was looking for this since the beginning of me using MLAPI and I figured I'd add this. I'm open to discussion.
I always wanted to directly set my channel type without having to rely on some names I didn't know what they did.
I feel this would help those setting up their custom netvar channels for example into not having to always reverse lookup what that channel actually does.