NetworkManager.OnDestroy calls ShutdownInternal but does not set m_ShuttingDown

[JayPeet]

Description

It seems that m_ShuttingDown is not set when the NetworkManager is shutdown via OnDestroy.
I am not sure if this is intentional, but it means that any code which queries that in its OnNetworkDespawn is unable to react based on the despawn being due to network shutdown.

[NoelStephensUnity]

@JayPeet
There are two places that OnDestroy is invoked:
NetworkManager.OnApplicationQuit and NetworkManager.OnSceneUnloaded.
Since the NetworkManager lives in the DDOL then that is typically something that happens intentionally, which you have control over when that happens unless it is an application exit (OnApplicationQuit).
Take a look at #2618 which adds m_ShuttingDown being set to true when the application is quitting/exiting.

Was the scenario you are describing happening when the application is quitting or is there some other scenario where NetworkManager is destroyed that you are experiencing?

[JayPeet]

This is happening specifically in editor when exiting play mode, we have some OnNetworkDespawn implementations which end up spawning new objects in during the shutdown of the NetworkManager, and we are unable to check if its shutting down since the bool is not set

I can probably get around it in editor by checking if the editor is exiting playmode :)

[NoelStephensUnity]

@JayPeet
Thank you for taking the time to give me the specifics so I could better determine if this has been fixed in the up-coming v1.5.2 patch. The specifics to the issue you are encountering and the pending fix:
When you exit play mode within the editor the OnApplicationQuit method is invoked.
The changes to NetworkManager in PR-2618 resolves that issue and the patch for this is coming really soon.
For the time being, you can either use the develop branch or make that change locally to get around that issue until the v1.5.2 patch is public.
👍

I am closing this issue as being fixed in #2629.