ClientNetworkTransform does not allow for server to commit after changing ownership

[AlexEnnerfelt]

Description

If a NetworkObject that has a ClientNetworkTransform (implemented as per the documentation) the Host/Server can commit the transform while it has not yet changed ownership. When another client takes ownership, the ability to commit transform is removed from the Server (so far so good) If the server then has the ownership returned to it, it will still not be allowed to commit transform.

Reproduce Steps

1. Set up NetworkObject with ClientNetworkTransform
2. Change ownership to client 1 (server loses right to commit transform)
3. Change ownership to client 0 (the Host)
4. The host still can't commit transform

Actual Outcome

The Host cannot commit transform for an owned object with ClientNetworkTransform when it has previously been owned by another client.

Expected Outcome

The Host should be treated as a client and regain right to commit transform on a ClientNetworkTransform despite having previously been owned by another client.

Screenshots

If applicable, add screenshots to help explain your problem.

Environment

• OS: Wibndows 11
• Unity Version: 2022.2.19
• Netcode Version: 1.4.0
• Netcode Commit: latest release in the unity registry

Additional Context

Add any other context about the problem here. Logs, code snippets would be useful here but please also consider attaching a minimal Unity project that reproduces the issue.

[AlexEnnerfelt]

Just realized that I was getting warnings that the change was happening while the some behaviours were disabled. I had to refactor a bit, but it does strike me as a problem that the ownerclientid changed in the editor, but it's not triggering certain thing in the behaviours.

[AlexEnnerfelt]

Is there any guidance on how to deal with Networkbehaviours that were not active during ownership assignment, like say for example the NetworkTransform

[AlexEnnerfelt]

I reverted back to Netcode 1.3.1 and all of my Networktransform issues went away

[NoelStephensUnity]

@AlexEnnerfelt
I would like to investigate this scenario further but have some questions about the issue you ran into.
The following project allows you to change the ownership of a "follower" object that follows the player that owns the object.
The players automatically just move in a circular pattern when connected (for simplicity sakes) and hitting the "space bar" on the host side changes the owner. I am able to switch between owners and all NetworkTransforms used are ownership authoritative and it appears switching ownership between multiple instances (had three local instances running with one as a host) and couldn't replicate the issue you described:
OwnershipChanges.zip

Could you further describe what it was that caused it to stop updating after ownership changed the second time back to the host? Also, if you can describe why the host side NetworkTransform was disabled and perhaps when that happened?

It will help me track down the issue you ran into.

[AlexEnnerfelt]

It seems like it was caused by that the server does not invoke the OnOwnershipGained when ownership is changed to server
it invoked OnOwnershipRemoved. My solution that made ClientNetworkTransform work again is:

public class ExtendedClientNetworkTransform : NetworkTransform
    {
        /// <summary>
        /// Used to determine who can write to this transform. Owner client only.
        /// This imposes state to the server. This is putting trust on your clients. Make sure no security-sensitive features use this transform.
        /// </summary>
        protected override bool OnIsServerAuthoritative()
        {
            return false;
        }

        public override void OnGainedOwnership()
        {
            base.OnGainedOwnership();
            if (IsServer && OwnerClientId != NetworkManager.LocalClientId)
            {
                OnLostOwnership();
            }
        }

        public override void OnLostOwnership()
        {
            base.OnLostOwnership();
            if (IsServer && OwnerClientId == NetworkManager.LocalClientId)
            {
                OnGainedOwnership();
            }
        }
    }

Credit David Gilbert on the Discord

[NoelStephensUnity]

@AlexEnnerfelt
Ahhh... interesting...
Was this happening on the player object specifically or just some other dynamically spawned or in-scene placed NetworkObject?

[Laumania]

Just wanted to tip in on this one too, as I have spend some hours now trying to figure what I messed up. Turns out @AlexEnnerfelt fix makes my game work again too.
I created a little video showing the issue and that it works after the fix (however, first time the clone didn't pick up the code change, so it didn't work but I figure it out and didn't wanted to redo the video :)

https://www.youtube.com/watch?v=JxuNejhd8EM

Don't know if this help you @NoelStephensUnity just wanted to let you know that the fix from above actually worked for me too.