NetworkObject ownership is not returned to the server.

[junyeop]

Describe the bug

DontDestroyWithOwner is not working properly.
Giving ownership of an NetworkObject to the client and disconnecting does not return ownership of the NetworkObject to the server.

To Reproduce

1. Set DontDestroyWithOwner to "true" and spawn a NetworkObject using the SpawnWithOwnership function.
2. Repeat step 1 several times.
3. Disconnects a client that has NetworkObject ownership.
4. Only half of NetworkObject ownership is returned to the server.

Actual outcome
Only half of NetworkObject ownership is returned to the server.

Expected outcome
All NetworkObject ownership should be returned to the server.

Environment

• OS: Windows 10
• Unity Version: 2020.3.11f1
• MLAPI Version: v0.1.0

Spawn Script
var instance = Instantiate(prefab, transform.position, transform.rotation);
instance.GetComponent().DontDestroyWithOwner = true;
instance.GetComponent().SpawnWithOwnership(NetworkManager.Singleton.ConnectedClientsList.First().ClientId);

Disconnect Script
m_NetworkManager.StopClient();

[junyeop]

NetworkManager.cs

I think the problem is that it increments the index to access OwnedObjects each time, but skips once because the RemoveOwnership function changes OwnedObjects.

for (int i = 0; i < ConnectedClients[clientId].OwnedObjects.Count; i++) 
{
    if (ConnectedClients[clientId].OwnedObjects[i] != null)
    {
        if (!ConnectedClients[clientId].OwnedObjects[i].DontDestroyWithOwner)
        {
            if (NetworkSpawnManager.CustomDestroyHandlers.ContainsKey(ConnectedClients[clientId].OwnedObjects[i].PrefabHash))
            {
                NetworkSpawnManager.CustomDestroyHandlersConnectedClients[clientId].OwnedObjects[i].PrefabHash;
                NetworkSpawnManager.OnDestroyObject(ConnectedClients[clientId].OwnedObjects[i].NetworkObjectId, false);
            }
            else
            {
                Destroy(ConnectedClients[clientId].OwnedObjects[i].gameObject);
            }
          }
        else
        {
            ConnectedClients[clientId].OwnedObjects[i].RemoveOwnership(); 
        }
    }
}

[will-mearns]

Tracking this in MTT-1002

[TwoTenPvP]

Thanks for reporting this!

You are totally correct that the issue was with the indexing and removal from that list.

The issue is fixed in #1181