Merged
Conversation
Signed-off-by: snoppy <michaleli@foxmail.com>
imSanko
approved these changes
Jun 17, 2024
Contributor
imSanko
left a comment
imSanko
left a comment
There was a problem hiding this comment.
Those are some serious Typos
tianyizheng02
requested changes
Jun 17, 2024
Contributor
tianyizheng02
left a comment
tianyizheng02
left a comment
There was a problem hiding this comment.
I found more typos but GitHub won't let me add comments on them:
- On line 79 of
points_are_collinear_3d.py, "or" is misspelled as "of" - On line 81 of that same file, "Since" is misspelled as "Sine"
- On line 4 of
convolution_neural_network.py, "Handing Writing" should be "Handwriting" - On line 307 of that same file, it says "Training Complished" but "Complished" isn't a real word; I think it's supposed to say "Complete"?
- On line 356 of that same file, it says "on other file" but I think it's supposed to say "in another file"? I'm not sure what file the author was referring to
cclauss
approved these changes
Jun 17, 2024
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
Member
|
Were these misspellings found with a tool? |
Contributor
No, I just visually inspected the files. |
tianyizheng02
approved these changes
Jun 17, 2024
cclauss
added a commit
to cclauss/Python
that referenced
this pull request
Sep 30, 2024
* chore: fix typos Signed-off-by: snoppy <michaleli@foxmail.com> * Apply suggestions from code review Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com> --------- Signed-off-by: snoppy <michaleli@foxmail.com> Co-authored-by: Christian Clauss <cclauss@me.com> Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
cclauss
added a commit
to cclauss/Python
that referenced
this pull request
Sep 30, 2024
* chore: fix typos Signed-off-by: snoppy <michaleli@foxmail.com> * Apply suggestions from code review Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com> --------- Signed-off-by: snoppy <michaleli@foxmail.com> Co-authored-by: Christian Clauss <cclauss@me.com> Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist: