Skip to content

Targeting netstandard2.0, net45, net40#64

Closed
mwhelan wants to merge 4 commits intoTestStack:masterfrom
mwhelan:netstandard20
Closed

Targeting netstandard2.0, net45, net40#64
mwhelan wants to merge 4 commits intoTestStack:masterfrom
mwhelan:netstandard20

Conversation

@mwhelan
Copy link
Copy Markdown
Member

@mwhelan mwhelan commented Aug 10, 2017

First cut at netstandard2.0 support. with multi-targeting for .Net 4.5 and .Net 4.0 also

  • Removed PublicApiGenerator and commented out the one test that uses it
  • Couldn't get tests working with .Net 4.0

Everything compiles and all the tests pass.

@josephwoodward
Copy link
Copy Markdown

Nice! What's stopping you targeting a lower version of the .NET Standard out of interest?

@mwhelan
Copy link
Copy Markdown
Member Author

mwhelan commented Aug 11, 2017

Naivety probably! :-) What do you recommend?

The main issue preventing us porting before now was AutoFixture not having been ported so netstandard2.0 helped with that.

@josephwoodward
Copy link
Copy Markdown

josephwoodward commented Aug 11, 2017

AutoFixture not supporting .NET Standard has been a thorn in the side of a few projects. Luckily it looks like the port has almost been completed, and judging by the pull request it looks like it'll target .NET Standard 1.5, so there's scope to drop the target down to 1.5 once it's eventually released, in the meantime netstandard 2.0 is the next best thing.

@josephwoodward
Copy link
Copy Markdown

Looks like AutoFixture .NET Core changes have been merged and ready for release in v4 which is good news.

@robdmoore
Copy link
Copy Markdown
Member

robdmoore commented Sep 12, 2017 via email

@mwhelan
Copy link
Copy Markdown
Member Author

mwhelan commented Sep 13, 2017

Good to know, thanks!

@josephwoodward
Copy link
Copy Markdown

Probably worth merging this then targeting lower .NET Standard versions in a separate pull request.

@josephwoodward
Copy link
Copy Markdown

Any idea when we can get this merged (I see AutoFixture 4 RC1 has now been released)

@luk355
Copy link
Copy Markdown

luk355 commented Dec 12, 2018

AutoFixture v4 is now stable. Whats missing in this PR to get merged, @mwhelan?

Due to namespace changes in AutoFixture v4, its hard to consume this package together with latest version of AutoFixture.

Happy to help to with any outstanding work.

@robdmoore robdmoore mentioned this pull request Jan 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants