Landing page by gmorer · Pull Request #102 · Seluj78/PyMatcha

gmorer · 2020-02-23T23:06:23Z

No description provided.

accesslint

There are accessibility issues in these changes.

accesslint · 2020-02-23T23:06:30Z

frontend/src/components/input.js

+	<div className={`field ${OuterClass}`} style={outerStyle}>
+		{ !!icon ?
+			<p className='control has-icons-left'>
+				<input className={`input ${InnerClass}`} type={type} placeholder={placeholder} style={innerStyle} value={value} onChange={onChange(setValue)} />


Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.

accesslint · 2020-02-23T23:06:30Z

frontend/src/components/input.js

+						<i className={icon} />
+					</span>
+			</p> :
+			<input className={`input ${InnerClass}`} type={type} placeholder={placeholder} style={innerStyle} />


Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.

accesslint · 2020-02-23T23:06:30Z

frontend/src/components/login_card.js

+				<div className="notification is-danger" style={{paddingTop: '0.5em', paddingBottom: '0.5em'}} > { state } </div>
+			}
+			<Loading style={{ position: 'absolute', left: '50%', top: '50%', opacity: state === 'loading' ? '1' : '0', ...effectDuration(1) }} />
+			<Input {...emailInput(email, setEmail, state)} />


Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.

accesslint · 2020-02-23T23:06:30Z

frontend/src/components/login_card.js

+			}
+			<Loading style={{ position: 'absolute', left: '50%', top: '50%', opacity: state === 'loading' ? '1' : '0', ...effectDuration(1) }} />
+			<Input {...emailInput(email, setEmail, state)} />
+			<Input {...passwordInput(password, setPassword, state)} />


Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.

accesslint · 2020-02-23T23:06:31Z

frontend/src/components/register_card.js

+				<div className="notification is-danger" style={{paddingTop: '0.5em', paddingBottom: '0.5em'}}> { state } </div>
+			}
+			< Loading style={{ position: 'absolute', left: '50%', top: '50%', opacity: state === 'loading' ? '1' : '0', ...effectDuration(1) }} />
+			<Input {...emailInput(email, setEmail, state)} />


Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.

accesslint · 2020-02-23T23:06:31Z

frontend/src/components/register_card.js

+			}
+			< Loading style={{ position: 'absolute', left: '50%', top: '50%', opacity: state === 'loading' ? '1' : '0', ...effectDuration(1) }} />
+			<Input {...emailInput(email, setEmail, state)} />
+			<Input {...usernameInput(username, setUsername, state)} />


Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.

accesslint · 2020-02-23T23:06:31Z

frontend/src/components/register_card.js

+			< Loading style={{ position: 'absolute', left: '50%', top: '50%', opacity: state === 'loading' ? '1' : '0', ...effectDuration(1) }} />
+			<Input {...emailInput(email, setEmail, state)} />
+			<Input {...usernameInput(username, setUsername, state)} />
+			<Input {...passwordInput(password1, setPassword1, state)} placeholder="password" outerStyle={state === 'loading' ? discard('left') : {}} />


Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.

accesslint · 2020-02-23T23:06:31Z

frontend/src/components/register_card.js

+			<Input {...emailInput(email, setEmail, state)} />
+			<Input {...usernameInput(username, setUsername, state)} />
+			<Input {...passwordInput(password1, setPassword1, state)} placeholder="password" outerStyle={state === 'loading' ? discard('left') : {}} />
+			<Input {...passwordInput(password2, setPassword2, state)} placeholder="Password verification" outerStyle={state === 'loading' ? discard('right') : {}} />


Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.

* Testing dockerfile * Added end of license * docker working backend not responding * Testing dockerfile * Added end of license * docker working backend not responding * Added runtime file * Stage for mindiell * Removed useless space * Updated makefile. Docker now works ! Co-authored-by: gmorer <gmorer@users.noreply.github.com>

* Http call from front working, need CORS from back * Added cors, site map and fixed react home route * fix return name * [CHORE] Removed site-map and moved site loading fuction around Co-authored-by: gmorer <gmorer@users.noreply.github.com>

accesslint

There are accessibility issues in these changes.

accesslint · 2020-02-24T19:13:42Z

frontend/src/components/login_card.js

+				<div className="notification is-danger" style={{paddingTop: '0.5em', paddingBottom: '0.5em'}} > { state } </div>
+			}
+			<Loading style={{ position: 'absolute', left: '50%', top: '50%', opacity: state === 'loading' ? '1' : '0', ...effectDuration(1) }} />
+			<Input {...usernameInput(username, setUsername, state)} />


Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.

accesslint · 2020-02-24T19:13:43Z

frontend/src/components/login_card.js

+			}
+			<Loading style={{ position: 'absolute', left: '50%', top: '50%', opacity: state === 'loading' ? '1' : '0', ...effectDuration(1) }} />
+			<Input {...usernameInput(username, setUsername, state)} />
+			<Input {...passwordInput(password, setPassword, state)} />


Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.

accesslint · 2020-02-24T19:13:43Z

frontend/src/components/register_card.js

+			<Input {...usernameInput(username, setUsername, state)} />
+			<Input {...passwordInput(password1, setPassword1, state)} placeholder="password" outerStyle={state === 'loading' ? discard('left') : {}} />
+			<span style={ !password_ok && !!email ? {boxShadow: "red 0px 0px 1px 1px"} : {}}>
+				<Input {...passwordInput(password2, setPassword2, state)} placeholder="Password verification" outerStyle={state === 'loading' ? discard('right') : {}} />


Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.

accesslint

There are accessibility issues in these changes.

accesslint · 2020-02-24T19:30:26Z

frontend/src/components/login_card.js

+				<div className="notification is-danger" style={{paddingTop: '0.5em', paddingBottom: '0.5em'}} > { state } </div>
+			}
+			<Loading style={{ position: 'absolute', left: '50%', top: '50%', opacity: state === 'loading' ? '1' : '0', ...effectDuration(1) }} />
+			<Input {...usernameInput(username, setUsername, state)} />


Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.

accesslint · 2020-02-24T19:30:26Z

frontend/src/components/login_card.js

+			}
+			<Loading style={{ position: 'absolute', left: '50%', top: '50%', opacity: state === 'loading' ? '1' : '0', ...effectDuration(1) }} />
+			<Input {...usernameInput(username, setUsername, state)} />
+			<Input {...passwordInput(password, setPassword, state)} />


Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.

accesslint · 2020-02-24T19:30:26Z

frontend/src/components/register_card.js

+			<Input {...usernameInput(username, setUsername, state)} />
+			<Input {...passwordInput(password1, setPassword1, state)} placeholder="password" outerStyle={state === 'loading' ? discard('left') : {}} />
+			<span style={ !password_ok && !!email ? {boxShadow: "red 0px 0px 1px 1px"} : {}}>
+				<Input {...passwordInput(password2, setPassword2, state)} placeholder="Password verification" outerStyle={state === 'loading' ? discard('right') : {}} />


Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.

gmorer requested a review from Seluj78 February 23, 2020 23:06

accesslint bot suggested changes Feb 23, 2020

View reviewed changes

Seluj78 force-pushed the landing_page branch from 13af34c to af7908c Compare February 23, 2020 23:55

gmorer and others added 7 commits February 24, 2020 01:04

login card

bec1f8e

landing page with cool login effect

e6b0b09

Http call (#58)

e649599

* Http call from front working, need CORS from back * Added cors, site map and fixed react home route * fix return name * [CHORE] Removed site-map and moved site loading fuction around Co-authored-by: gmorer <gmorer@users.noreply.github.com>

register block

57575aa

Work in progress register

07a5d24

get api returns

e9cb545

Seluj78 force-pushed the landing_page branch from f411d6a to e9cb545 Compare February 24, 2020 00:04

Seluj78 and others added 2 commits February 24, 2020 19:37

Fixed error on register

87cd510

Working!

5b65e81

accesslint bot suggested changes Feb 24, 2020

View reviewed changes

Merge branch 'dev' into landing_page

180b22e

accesslint bot suggested changes Feb 24, 2020

View reviewed changes

Seluj78 merged commit 5f4dd87 into dev Feb 24, 2020

Seluj78 deleted the landing_page branch February 24, 2020 19:30

Conversation

gmorer commented Feb 23, 2020

Uh oh!

accesslint bot left a comment

Choose a reason for hiding this comment

Uh oh!

accesslint bot Feb 23, 2020

Choose a reason for hiding this comment

Uh oh!

accesslint bot Feb 23, 2020

Choose a reason for hiding this comment

Uh oh!

accesslint bot Feb 23, 2020

Choose a reason for hiding this comment

Uh oh!

accesslint bot Feb 23, 2020

Choose a reason for hiding this comment

Uh oh!

accesslint bot Feb 23, 2020

Choose a reason for hiding this comment

Uh oh!

accesslint bot Feb 23, 2020

Choose a reason for hiding this comment

Uh oh!

accesslint bot Feb 23, 2020

Choose a reason for hiding this comment

Uh oh!

accesslint bot Feb 23, 2020

Choose a reason for hiding this comment

Uh oh!

accesslint bot left a comment

Choose a reason for hiding this comment

Uh oh!

accesslint bot Feb 24, 2020

Choose a reason for hiding this comment

Uh oh!

accesslint bot Feb 24, 2020

Choose a reason for hiding this comment

Uh oh!

accesslint bot Feb 24, 2020

Choose a reason for hiding this comment

Uh oh!

accesslint bot left a comment

Choose a reason for hiding this comment

Uh oh!

accesslint bot Feb 24, 2020

Choose a reason for hiding this comment

Uh oh!

accesslint bot Feb 24, 2020

Choose a reason for hiding this comment

Uh oh!

accesslint bot Feb 24, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants