Remove the ^ from regex that is looking for Wiki article links.#114
Merged
REMitchell merged 1 commit intoREMitchell:masterfrom Feb 12, 2023
Merged
Remove the ^ from regex that is looking for Wiki article links.#114REMitchell merged 1 commit intoREMitchell:masterfrom
^ from regex that is looking for Wiki article links.#114REMitchell merged 1 commit intoREMitchell:masterfrom
Conversation
The links being scraped are now absolute (full) URLs. The rule should look for links that contain `/wiki/` rather than start with `/wiki/`. Ex: https://en.wikipedia.org/wiki/Benevolent_dictator_for_life rather than /wiki/Benevolent_dictator_for_life'
ACPK
changed the title
^ from Regex^ from Regex that is looking for Wiki article links.
ACPK
changed the title
^ from Regex that is looking for Wiki article links.^ from regex that is looking for Wiki article links.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: This relates to page 73 as the same regex on page 78 doesn't contain the
^.The links being scraped are absolute (full) URLs. The rule should look for links that contain
/wiki/rather than start with/wiki/.