Added github workflow action to deploy changes on "push"#3
Merged
PythonCHB merged 14 commits intoPythonCHB:masterfrom Aug 26, 2020
Merged
Added github workflow action to deploy changes on "push"#3PythonCHB merged 14 commits intoPythonCHB:masterfrom
PythonCHB merged 14 commits intoPythonCHB:masterfrom
Conversation
minor edit (also to test the buildout using github workflow).
| - name: Install dependencies | ||
| run: | | ||
| python -m pip install --upgrade pip | ||
| pip install flake8 pytest |
Collaborator
There was a problem hiding this comment.
why these? They'd be pretty common for actual code, but in this case, we're only building Shinx docs.
PythonCHB
approved these changes
Aug 26, 2020
Owner
PythonCHB
left a comment
PythonCHB
left a comment
There was a problem hiding this comment.
might as well give it a try.
| - uses: actions/checkout@v2 | ||
| - uses: actions/setup-python@v2 | ||
| with: | ||
| python-version: "2.7" |
Owner
There was a problem hiding this comment.
some of thjat code is old, but we probably should go to py3 now
| @@ -0,0 +1,26 @@ | |||
| name: Code Quality | |||
Owner
There was a problem hiding this comment.
I"m not sure running flake8u in this is worth it -- this isn't really a code project.
It would be nice to clean up all the code samples -- some of them are pretty old, but I dont hink we need to run a linter on every merge.
Contributor
Author
|
W.r.t to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.