Skip to content

JS Pull#283

Closed
sjolundjohn wants to merge 6 commits intoLoopKit:masterfrom
sjolundjohn:master
Closed

JS Pull#283
sjolundjohn wants to merge 6 commits intoLoopKit:masterfrom
sjolundjohn:master

Conversation

@sjolundjohn
Copy link
Copy Markdown

No description provided.

@bharat
Copy link
Copy Markdown

bharat commented Nov 27, 2016

did you mean to submit this as a pull request? I'm guessing you want to keep these changes in your own fork.. :-)

@sjolundjohn
Copy link
Copy Markdown
Author

sjolundjohn commented Nov 27, 2016 via email

@ps2 ps2 closed this Dec 1, 2016
ps2 pushed a commit that referenced this pull request Nov 16, 2020
…rideIfActive to glucoseTargetRangeConsideringOverrides(consideringPotentialCarbEntry ...?) (#283)

* checkpoint

* checkpoint: change LoopSettings.glucoseTargetRangeScheduleApplyingOverrideIfActive to glucoseTargetRangeConsideringOverrides(consideringPotentialCarbEntry potentialCarbEntry: NewCarbEntry?)

* Rename `glucoseTargetRangeScheduleMaybeApplyingOverride(consideringPotentialCarbEntry:` to `effectiveGlucoseTargetRangeSchedule(consideringPotentialCarbEntry:`

* Rename glucoseTargetRangeScheduleApplyingOverrideIfActive to effectiveGlucoseTargetRangeSchedule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants